lattice/pyerrors
1
0
Fork 0
mirror of https://github.com/fjosw/pyerrors.git synced 2025-05-15 03:53:41 +02:00
Code Issues Projects Releases Packages Wiki Activity

fix: bug in estimation of chisquare for correlated fit fixed, tests

Browse source 
added.
This commit is contained in:
Fabian Joswig 2022-05-26 13:52:05 +01:00
parent ff5540d667
commit e7f5961cd6
2 changed files with 9 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

6
pyerrors/fits.py
View file

@ -525,6 +525,10 @@ def _standard_fit(x, y, func, silent=False, **kwargs):
fit_result = scipy.optimize.least_squares(chisqfunc_residuals_corr, fit_result.x, method='lm', ftol=1e-15, gtol=1e-15, xtol=1e-15)
chisquare = np.sum(fit_result.fun ** 2)
if kwargs.get('correlated_fit') is True:
assert np.isclose(chisquare, chisqfunc_corr(fit_result.x), atol=1e-14)
else:
assert np.isclose(chisquare, chisqfunc(fit_result.x), atol=1e-14)
output.iterations = fit_result.nfev
@ -585,7 +589,7 @@ def _standard_fit(x, y, func, silent=False, **kwargs):
output.fit_parameters = result
output.chisquare = chisqfunc(fit_result.x)
output.chisquare = chisquare
output.dof = x.shape[-1] - n_parms
output.p_value = 1 - chi2.cdf(output.chisquare, output.dof)