From 6d1f8f7f1baa7efc26b0964af041af97347cb491 Mon Sep 17 00:00:00 2001
From: Justus Kuhlmann <justus@kuhl-mann.de>
Date: Fri, 10 Apr 2026 10:28:28 +0200
Subject: [PATCH] add NotImplemented warning for openQCD filter

---
 corrlib/find.py    |  5 ++++-
 tests/find_test.py | 28 +++++++++++++++++++++++++++-
 2 files changed, 31 insertions(+), 2 deletions(-)

diff --git a/corrlib/find.py b/corrlib/find.py
index 9d07a1c..1c985e2 100644
--- a/corrlib/find.py
+++ b/corrlib/find.py
@@ -11,6 +11,7 @@ from typing import Any, Optional, Union
 from pathlib import Path
 import datetime as dt
 from collections.abc import Callable
+import warnings
 
 
 def _project_lookup_by_alias(db: Path, alias: str) -> str:
@@ -162,7 +163,7 @@ def _db_lookup(db: Path, ensemble: str, correlator_name: str, code: str, project
     return results
 
 
-def _sfcf_drop(param, **kwargs):
+def _sfcf_drop(param: dict[str, Any], **kwargs: Any) -> bool:
         if 'offset' in kwargs:
             if kwargs.get('offset') != param['offset']:
                 return True
@@ -288,6 +289,8 @@ def openQCD_filter(results:pd.DataFrame, **kwargs: Any) -> pd.DataFrame:
         The filtered results.
 
     """
+    warnings.warn("A filter for openQCD parameters is no implemented yet.", Warning)
+
     return results
 
 
diff --git a/tests/find_test.py b/tests/find_test.py
index 36d687e..f512f15 100644
--- a/tests/find_test.py
+++ b/tests/find_test.py
@@ -256,7 +256,33 @@ def test_sfcf_drop() -> None:
 
 
 def test_openQCD_filter() -> None:
-    assert True
+    record_0 = ["f_A", "ensA", "sfcf", "archive/SF_A/f_A/Project_A.json.gz::asdfasdfasdf", "SF_A", '{"par_A": 5.0, "par_B": 5.0}', "projects/SF_A/input.in",
+            '2025-03-26 12:55:18.229966', '2025-03-26 12:55:18.229966']
+    record_1 = ["f_A", "ensA", "sfcf", "archive/SF_A/f_A/Project_A.json.gz::asdfasdfasdf", "SF_A", '{"par_A": 5.0, "par_B": 5.0}', "projects/SF_A/input.in",
+            '2025-03-26 12:55:18.229966', '2025-03-26 12:55:18.229966']
+    record_2 = ["f_P", "ensA", "sfcf", "archive/SF_A/f_A/Project_A.json.gz::asdfasdfasdf", "SF_A", '{"par_A": 5.0, "par_B": 5.0}', "projects/SF_A/input.in",
+            '2025-03-26 12:55:18.229966', '2025-03-26 12:55:18.229966']
+    record_3 = ["f_P", "ensA", "sfcf", "archive/SF_A/f_A/Project_A.json.gz::asdfasdfasdf", "SF_A", '{"par_A": 5.0, "par_B": 5.0}', "projects/SF_A/input.in",
+            '2025-03-26 12:55:18.229966', '2025-03-26 12:55:18.229966']
+    data = [
+        record_0,
+        record_1,
+        record_2,
+        record_3,
+    ]
+    cols = ["name",
+            "ensemble",
+            "code",
+            "path",
+            "project",
+            "parameters",
+            "parameter_file",
+            "created_at",
+            "updated_at"]
+    df = pd.DataFrame(data,columns=cols)
+
+    with pytest.warns(Warning):
+        find.openQCD_filter(df, a = "asdf")
 
 
 def test_code_filter() -> None: