From 48b95f27003cc319e1b2ca043a5f938ffeec3359 Mon Sep 17 00:00:00 2001 From: Justus Kuhlmann Date: Tue, 7 Jul 2026 13:51:58 +0200 Subject: [PATCH] use warnings better, small typo correction in test --- corrlib/find.py | 3 ++- corrlib/tracker.py | 7 ++++--- tests/find_test.py | 3 +-- tests/import_project_test.py | 2 +- 4 files changed, 8 insertions(+), 7 deletions(-) diff --git a/corrlib/find.py b/corrlib/find.py index dd4be13..18c4001 100644 --- a/corrlib/find.py +++ b/corrlib/find.py @@ -2,6 +2,7 @@ import datetime as dt import json import os import sqlite3 +import warnings from collections.abc import Callable from pathlib import Path from typing import Any @@ -287,7 +288,7 @@ def openQCD_filter(results:pd.DataFrame, **kwargs: Any) -> pd.DataFrame: The filtered results. """ - raise Warning("A filter for openQCD parameters is no implemented yet.") + warnings.warn("A filter for openQCD parameters is no implemented yet.", Warning, 1) return results diff --git a/corrlib/tracker.py b/corrlib/tracker.py index bd84bff..0a962fa 100644 --- a/corrlib/tracker.py +++ b/corrlib/tracker.py @@ -1,5 +1,6 @@ import os import shutil +import warnings from configparser import ConfigParser from pathlib import Path @@ -80,7 +81,7 @@ def save(path: Path, message: str, files: list[Path] | None=None) -> None: files = [path / f for f in files] dl.save(files, message=message, dataset=path) elif tracker == 'None': - raise Warning("Tracker 'None' does not implement save.") + warnings.warn("Tracker 'None' does not implement save.", Warning, 1) else: raise ValueError(f"Tracker {tracker} is not supported.") @@ -122,7 +123,7 @@ def unlock(path: Path, file: Path) -> None: if tracker == 'datalad': dl.unlock(os.path.join(path, file), dataset=path) elif tracker == 'None': - raise Warning("Tracker 'None' does not implement unlock.") + warnings.warn("Tracker 'None' does not implement unlock.", Warning, 1) else: raise ValueError(f"Tracker {tracker} is not supported.") return @@ -169,7 +170,7 @@ def drop(path: Path, reckless: str | None=None) -> None: if tracker == 'datalad': dl.drop(path, reckless=reckless) elif tracker == 'None': - raise Warning("Tracker 'None' does not implement drop.") + warnings.warn("Tracker 'None' does not implement drop.", Warning, 1) else: raise ValueError(f"Tracker {tracker} is not supported.") return diff --git a/tests/find_test.py b/tests/find_test.py index 2144001..b462634 100644 --- a/tests/find_test.py +++ b/tests/find_test.py @@ -306,8 +306,7 @@ def test_openQCD_filter() -> None: "updated_at"] df = pd.DataFrame(data,columns=cols) - with pytest.warns(Warning): - find.openQCD_filter(df, a = "asdf") + find.openQCD_filter(df, a = "asdf") def test_code_filter() -> None: diff --git a/tests/import_project_test.py b/tests/import_project_test.py index 685d2cf..8493773 100644 --- a/tests/import_project_test.py +++ b/tests/import_project_test.py @@ -10,7 +10,7 @@ def test_toml_check_measurement_data() -> None: "param_file": "/path/to/file", "version": "1.1", "prefix": "pref", - "cfg_seperator": "n", + "cfg_separator": "n", "names": ['list', 'of', 'names'] } }